Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor clean up in test class, add initial ContributionFormTrait #27947

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Minor clean up in test class, add initial ContributionFormTrait #27947

merged 1 commit into from
Oct 27, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Extract contribution page set up to trait, similar to event trait - I am building on this but having to work through a few tests so trying to break it down a bit

@civibot
Copy link

civibot bot commented Oct 27, 2023

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Oct 27, 2023
@eileenmcnaughton eileenmcnaughton force-pushed the page_trait branch 3 times, most recently from 835f38b to 17f1cb6 Compare October 27, 2023 00:31
@eileenmcnaughton eileenmcnaughton mentioned this pull request Oct 27, 2023
Merged
@eileenmcnaughton
Copy link
Contributor Author

test this please

1 similar comment
@eileenmcnaughton
Copy link
Contributor Author

test this please

@eileenmcnaughton eileenmcnaughton force-pushed the page_trait branch 4 times, most recently from 08744a3 to cf97494 Compare October 27, 2023 08:33
@eileenmcnaughton
Copy link
Contributor Author

test this please

@colemanw colemanw merged commit 3df424a into civicrm:master Oct 27, 2023
@colemanw colemanw deleted the page_trait branch October 27, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw