Use api to get price set metadata - Online Contribution Page

[eileenmcnaughton]

Overview

Use api to get price set metadata - Online Contribution Page

Before

The getCachedPriceSetDetail() is not otherwise used to assign values to the form but is used to retrieve metadata for form usage. As we are starting to expose it more (via BAO_Order->getPriceSetMetadata() it feels like now is the right time to switch to apiv4 - so we can rely on typing. In general when we expose things for public access they use apiv4 format.

After

Apiv4 used for retrieval, escaping added to smarty.

Technical Details

I filled all the text fields in civicrm_price_set, price_field & price_field value with script & fixed all the places that triggered my script - + a few more that didn't just for form.

Comments

There is also a recently merged regression fixed in here - @colemanw we should merge this before anyone hits it

Going through this exercise also reduces the risk of us accidentally introducing unescaped fields in future

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[colemanw]

Ok, I see this includes test coverage.