Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes core#2929: Don't crash a contribution because of a geocoding failure #27897

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

MegaphoneJon
Copy link
Contributor

Overview

Geocoding failures will cause a contribution to fail, giving a WSOD to the donor.

Before

WSOD.

After

Error logged in ConfigAndLog. Contribution completes.

Comments

Not really.

@civibot
Copy link

civibot bot commented Oct 23, 2023

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Oct 23, 2023
@mattwire
Copy link
Contributor

Agreed! We certainly shouldn't have potentially third-party code crashing something like this. However, wouldn't it be better to just wrap both provider calls in the existing try/catch rather than add a second one?

@MegaphoneJon
Copy link
Contributor Author

@mattwire I'm open to it, but I just tried a couple different ways and the existing patch is the simplest code I could come up with. Otherwise you have to add some nested ifs.

The two errors being caught are fairly different - one is a no geocoder selected issue, the other is an error returned from the geocoder.

@artfulrobot
Copy link
Contributor

Also, just noting that the CRM_Utils_GeocodeProvider::getConfiguredProvider() method's dockblock specifies a @return CRM_Utils_Geocode but that class doesn't exist... I think it means CRM_Utils_Geocode_Geocoder

Co-authored-by: Rich Lott <artfulrobot@users.noreply.github.com>
@mattwire mattwire merged commit afd82b7 into civicrm:master Oct 24, 2023
@MegaphoneJon MegaphoneJon deleted the geocoding-catch branch December 7, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants