Case Activity: use select2 for Medium field #27879

mlutfy · 2023-10-22T15:18:30Z

Overview

Uses select2 for the "Medium" field on Case Activities. This makes it more consistent with other select fields.

Before

After

Comments

I did a bit of cleanup because it seemed weird.

civibot · 2023-10-22T15:18:33Z

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

➡️ PR Demo site (can be rebuilt with the command test this please).
📖 Review standards
🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

colemanw · 2023-10-22T15:26:53Z

CRM/Case/Form/Activity.php

@@ -203,6 +203,10 @@ public function setDefaultValues() {
      }
      $this->assign('targetContactValues', empty($targetContactValues) ? FALSE : $targetContactValues);

+      if ($this->_activityId) {
+        $this->_encounterMedium = CRM_Core_DAO::getFieldValue('CRM_Activity_DAO_Activity', $this->_activityId, 'medium_id');


This is an undeclared property of the class so will cause warnings in php8. Why are we even setting it?

hmm yep - previously the variable was being set from buildQuickForm() and only used once in setDefaultValues(), so I moved it to setDefaultValues.

I updated my PR to simplify the code further. All these shenanigans around encounterMediums were odd, there is nothing special about this field.

shenanigans

Good word for it!

colemanw · 2023-10-22T17:34:22Z

CRM/Case/Form/Activity.php

+      if ($this->_activityId) {
+        $this->_defaults['medium_id'] = CRM_Core_DAO::getFieldValue('CRM_Activity_DAO_Activity', $this->_activityId, 'medium_id');
      }


I don't even know why this shenanigan still exists. Why wouldn't this value be set along with all the others by the call to parent::setDefaultValues() above?

There is no medium on regular activities.

The field exists though so shouldn't it be populated?

civicrm-core/xml/schema/Activity/Activity.xml

Lines 250 to 264 in baffc20

<field>

<name>medium_id</name>

<uniqueName>activity_medium_id</uniqueName>

<title>Activity Medium</title>

<type>int unsigned</type>

<default>NULL</default>

<comment>Activity Medium, Implicit FK to civicrm_option_value where option_group = encounter_medium.</comment>

<pseudoconstant>

<optionGroupName>encounter_medium</optionGroupName>

</pseudoconstant>

<html>

<type>Select</type>

</html>

<add>2.2</add>

</field>

I'm just saying that's why it's not unexpected to see encounter_medium code here.

I tested on a site and it does seem to work without those lines of code ($this->_defaults['medium_id'] = ..)

I checked the code and it certainly looks like the lines aren't needed. The setDefaultValues function does a pretty standard DAO->find(TRUE) and CRM_Core_DAO::storeValues() which is basically like SELECT *.

So it should work without it, and it does work without it. Let's remove it :)

Yep, I had a side-quest (joys of numeric custom fields), and now updated this PR to remove it.

demeritcowboy · 2023-10-22T19:49:15Z

jenkins retest this please

civibot bot added the master label Oct 22, 2023

colemanw reviewed Oct 22, 2023

View reviewed changes

mlutfy force-pushed the caseActMedium branch from 2018f43 to afb2a79 Compare October 22, 2023 17:15

colemanw reviewed Oct 22, 2023

View reviewed changes

Case Activity: use select2 for Medium field

10106de

mlutfy force-pushed the caseActMedium branch from afb2a79 to 10106de Compare October 22, 2023 19:04

demeritcowboy added the merge on pass label Oct 22, 2023

demeritcowboy merged commit 5843344 into civicrm:master Oct 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Case Activity: use select2 for Medium field #27879

Case Activity: use select2 for Medium field #27879

mlutfy commented Oct 22, 2023

civibot bot commented Oct 22, 2023

colemanw Oct 22, 2023

mlutfy Oct 22, 2023

colemanw Oct 22, 2023

colemanw Oct 22, 2023

demeritcowboy Oct 22, 2023

colemanw Oct 22, 2023

demeritcowboy Oct 22, 2023

mlutfy Oct 22, 2023

colemanw Oct 22, 2023

mlutfy Oct 22, 2023

demeritcowboy commented Oct 22, 2023

	<field>
	<name>medium_id</name>
	<uniqueName>activity_medium_id</uniqueName>
	<title>Activity Medium</title>
	<type>int unsigned</type>
	<default>NULL</default>
	<comment>Activity Medium, Implicit FK to civicrm_option_value where option_group = encounter_medium.</comment>
	<pseudoconstant>
	<optionGroupName>encounter_medium</optionGroupName>
	</pseudoconstant>
	<html>
	<type>Select</type>
	</html>
	<add>2.2</add>
	</field>

Case Activity: use select2 for Medium field #27879

Case Activity: use select2 for Medium field #27879

Conversation

mlutfy commented Oct 22, 2023

Overview

Before

After

Comments

civibot bot commented Oct 22, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

demeritcowboy commented Oct 22, 2023