Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix online contribution form Confirm page to get text from processor #27848

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Oct 17, 2023

Overview

Fix online contributioen form Confirm page to get text from processor

Note there is a deliberate change to pay later (cos it didn't make sense before) but otherwise this is just a refactor to get rid of contributeMode

Before

PayPal Std with $$
image

Paypal Std - free

image

Paylater (broken actually) - with money
image

Pay later - free
image

Dummy - free
image

Dummy - with payment
image

After

Paypal std with $
image

Paypal Std free
image

Pay later (with money)

image

Pay later free

image

Dummy free
image

Dummy with payment

image

Technical Details

Comments

@mattwire once this change is made the only way the contribution form still uses 'contributeMode' is in deciding whether to call the postProcess hook before doPayment because it will otherwise not be called when redirect happens.

This seems fairly easy to move to the Payment object - I'm just not quite sure on the name...
spitballing

supportsNoReturn()
supportsFormHookBeforePayment()
isNotReturnOnPayment()

thoughts?

image

@civibot
Copy link

civibot bot commented Oct 17, 2023

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Oct 17, 2023
@eileenmcnaughton eileenmcnaughton force-pushed the rem_contribute_mode branch 2 times, most recently from 3b2f78b to 7ae4278 Compare October 17, 2023 20:08
@eileenmcnaughton eileenmcnaughton changed the title Fix contribution page to get text from processor Fix online contributioen form Confirm page to get text from processor Oct 17, 2023
@eileenmcnaughton eileenmcnaughton changed the title Fix online contributioen form Confirm page to get text from processor Fix online contribution form Confirm page to get text from processor Oct 17, 2023
@mattwire mattwire merged commit 354fb14 into civicrm:master Oct 27, 2023
@eileenmcnaughton eileenmcnaughton deleted the rem_contribute_mode branch October 27, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants