Fix online contribution form Confirm page to get text from processor #27848
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix online contributioen form Confirm page to get text from processor
Note there is a deliberate change to pay later (cos it didn't make sense before) but otherwise this is just a refactor to get rid of
contributeMode
Before
PayPal Std with $$

Paypal Std - free
Paylater (broken actually) - with money

Pay later - free

Dummy - free

Dummy - with payment

After
Paypal std with $

Paypal Std free

Pay later (with money)
Pay later free
Dummy free

Dummy with payment
Technical Details
Comments
@mattwire once this change is made the only way the contribution form still uses 'contributeMode' is in deciding whether to call the
postProcess
hook beforedoPayment
because it will otherwise not be called when redirect happens.This seems fairly easy to move to the Payment object - I'm just not quite sure on the name...
spitballing
supportsNoReturn()
supportsFormHookBeforePayment()
isNotReturnOnPayment()
thoughts?