Fix online contribution form Confirm page to get text from processor

[eileenmcnaughton]

Overview

Fix online contributioen form Confirm page to get text from processor

Note there is a deliberate change to pay later (cos it didn't make sense before) but otherwise this is just a refactor to get rid of contributeMode

Before

PayPal Std with $$

Paypal Std - free

Paylater (broken actually) - with money

Pay later - free

Dummy - free

Dummy - with payment

After

Paypal std with $

Paypal Std free

Pay later (with money)

Pay later free

Dummy free

Dummy with payment

Technical Details

Comments

@mattwire once this change is made the only way the contribution form still uses 'contributeMode' is in deciding whether to call the postProcess hook before doPayment because it will otherwise not be called when redirect happens.

This seems fairly easy to move to the Payment object - I'm just not quite sure on the name...
spitballing

supportsNoReturn()
supportsFormHookBeforePayment()
isNotReturnOnPayment()

thoughts?

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗