Participant - Translate untranslated string

[colemanw]

Overview

Simplifies event title lookup and uses ts() instead of sprintf() so the string will be translated.

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[highfalutin]

Doing translation is good, but we lose some information with the change from CRM_Event_BAO_Event::getEvents() to CRM_Core_DAO::getFieldValue(). For example:

Before this PR: "Registration selections changed for Fall Fundraiser Dinner - March 19th, 2024 5:00 PM"

After this PR: "Registration selections changed for Fall Fundraiser Dinner"

[highfalutin]

(note: to r-run, view a participant record for an event with fee options. In the "Selections" section, click the "Change selections" link. After saving, view the contact's Activities.)

[colemanw]

Thanks @highfalutin - is the old version actually helpful? All of that code looks half-assed to me so I figured it was there by mistake. IMO adding the date to the subject is potentially confusing because it's unclear what date it's referring to: you'd think it's the date that the selections were changed, but it's not.

[highfalutin]

It is possible that an org would have multiple events with the same title on different dates (recurring events?), making it helpful to see the event date at a glance.

However, my guess is it's rare to have same-name events and have fee-selection changes that someone is looking for in the list of activities. And anyway, the activity is linked to the event via the participant record (source_record_id), and in the UI you can click through to see which event (on which date) it's referring to if you're confused.

So, my r-user assessment is that it's OK to remove the date. We shouldn't be shocked if we get some complaints. But we very well may not!

[colemanw]

We shouldn't be shocked if we get some complaints. But we very well may not!

If we get any, I guarantee they won't be in any language other than English!

[highfalutin]

Good point 😆