Smarty3 compatibilty with Contribution Amount tab

[eileenmcnaughton]

Overview

Fixes to the Amount tab in the contribution page set for Smarty3

Before

With smarty 3 at this url https://dmaster.localhost:32353/civicrm/admin/contribute/amount?reset=1&action=update&id=3&snippet=json we see

After

fixed

The code drives the display of the recurring pledge start date - see

Technical Details

Once I got down to it the problem was just silly use of variable names but in the process I

• simplified it by assigning json from the form layer
• added some of our standardised get functions
• fixed an e-notice on $isQuick - there are still a bunch of them but they are swallowed by the ajax rendering

Comments

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗