Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP 8.2] fix undefined property in CRM_Event_Form_SelfSvcUpdate #27769

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

jofranz
Copy link
Contributor

@jofranz jofranz commented Oct 10, 2023

Overview

Playing around learning if this is enough to fix a PHP deprecation

Before

Test failed:
Creation of dynamic property CRM_Event_Form_SelfSvcUpdate::$_userContext is deprecated

After

Test doesn't fail anymore?

@civibot
Copy link

civibot bot commented Oct 10, 2023

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Oct 10, 2023
@eileenmcnaughton
Copy link
Contributor

Just doing a quick grep & it looks like that property might be set but never used?

@eileenmcnaughton
Copy link
Contributor

Hmm this is annoying - I actually did do a cleanup on this form at some point but I can't find the PR - there are a bunch of undeclared properties in this one - I think #27770 is the gist of the previous work I did...

FYI - I think there are lots of easy wins on the php8.2 fails on the report tests

@eileenmcnaughton
Copy link
Contributor

I'm gonna merge this - even though I think the property / setting of it can be removed - the ultimate goal of this PR was to see the impact of it on tests (while removing one notice) so I want to facilitate that

@eileenmcnaughton eileenmcnaughton merged commit 9272ab1 into civicrm:master Oct 10, 2023
@jofranz jofranz deleted the fix_php_undefines_property branch October 12, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants