Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickSearch - Add Current Employer option #27766

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

colemanw
Copy link
Member

Overview

Adds "Current Employer" as a quicksearch option in the menubar.

@civibot
Copy link

civibot bot commented Oct 10, 2023

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Oct 10, 2023
@wyde22
Copy link
Contributor

wyde22 commented Oct 10, 2023

ok thanks but in the url share in this issue i can't see the new data in autocomplete results

@colemanw
Copy link
Member Author

ok thanks but in the url share in this issue i can see the new data in autocomplete results

I don't understand your comment. Can you please explain in detail how you tested and what the result was?

@wyde22
Copy link
Contributor

wyde22 commented Oct 10, 2023

oops i so sorry, i have a mistake in my reply. i just edit my reply with my correction. below this comment you can see the screenshot of my problem :

CiviCRM-Home-core-27766-1257c

CiviCRM-Home-core-27766-1257c (1)
and i have test your demo and i can't see the employer in the quick search

@composerjk
Copy link
Contributor

You may need to go to the Settings for Search Preferences on the demo site to add the Current Employer option.

@wyde22
Copy link
Contributor

wyde22 commented Oct 10, 2023

ok perfect i can see the new data now. If i want to add a new data (custom field for example) for this quicksearch i have a specific hook or event symfony perhaps ?

It's necessary to modify CRM/Core/SelectValues.php ?

@colemanw
Copy link
Member Author

@wyde22 we really try to keep PR discussions focused on the question of "should this PR be merged." Currently we have 138 open PRs!!! It's a lot to manage and we need all the help we can get. You are the reviewer of this PR so it's your job to say "I have tested this PR and it works" or "I have tested this PR and it needs work before it can be merged". That will help us reduce the number to 137 :)

@wyde22
Copy link
Contributor

wyde22 commented Oct 10, 2023

ok @Coleman :). No problem i tested this PR and it works. I can see the current employer in the quicksearch. Thanks

@colemanw colemanw merged commit 76df9f1 into civicrm:master Oct 10, 2023
@colemanw colemanw deleted the quickSearchEmployer branch October 10, 2023 21:45
@colemanw
Copy link
Member Author

Thanks @wyde22 - to answer your questions, custom fields should be available automatically in the list (as long as you remember to check the "Searchable" checkbox when you create the custom field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants