Remove discussion about format from html box on email form

[eileenmcnaughton]

Overview

Remove discussion about format from html box on email form

Before

After

Technical Details

Comments

I really can't think of anything else useful to say here - but this gets rid of the actively bad text. We could do more on the plain text bit (eg. remove it!) but out of scope for this PR

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[mlutfy]

Instead of "potentially obsolete":

• will be removed from CiviCRM in a future version
• text version is automatically generated

What happens if the WYSIWYG is disabled?

[eileenmcnaughton]

@mlutfy to the last - the html box is still the place to configure the message - you just have to write it in html I guess? I don't know who disables WYSIWIG or why - but I assume they still have to ensure that any fields that expect html have entered html?

Re wording - I updated to this

One more note - I thought about having the accordian closed rather than open - but then I figured that should only be the case if empty - which seems fiddly & makes me think we might be better to focus on the Message Admin UI instead. Hmm maybe that's a case for closing by default - ie it's used from more than one screen & the main one where you might want to encourage them to empty it out is kinda deprecated.

[mlutfy]

ah yeah, good point about the HTML/WYSIWYG.

I think I only have one client who disables the editor, because they didn't really need it, and had some security concerns.

Even one client who has a massively old-school kind of membership (with text email) still generate HTML by default (because the staff aren't that old school).

Changes look good to me. thanks!

[eileenmcnaughton]

@mlutfy they still generate html by default? I'm confused by what you mean?

[mlutfy]

You can ignore my comment. I was trying to think of various edge cases, and in both cases, working with HTML-only is fine (with auto-generated text version).

[eileenmcnaughton]

@mlutfy ok to merge? We can iterate if required