-
-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF] Fix up Message template gencode to work with Smarty 3 #27727
[REF] Fix up Message template gencode to work with Smarty 3 #27727
Conversation
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
43e16ab
to
dac2156
Compare
dac2156
to
f487011
Compare
]; | ||
$smarty->assign('ogNames', $ogNames); | ||
$smarty->assign('ovNames', $ovNames); | ||
$dir = $smarty->get_template_vars()['gencodeXmlDir'] . '/templates/message_templates/sample'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't matter per se but because we merged the smarty compatibility class getTemplateVars()
is preferred - that's the v3 version so at some point we need to swap although both work right now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeh it might matter more here because of https://github.com/civicrm/civicrm-core/pull/27727/files#diff-2131b62e0019c60c9029efe45018ac61ae5f687d791013825679af5f9bdf28edR17 doesn't use the compatibility class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok - we might as well punt switching that one then!
well it works! now just digging into some minor things I spotted while testing |
Overview
This modifies the way gencode works for message templates to make it work with smarty 3
Before
Gencode message template doesn't work with Smarty 3
After
Gencode Message template works with Smarty 3
ping @eileenmcnaughton @larssandergreen