Searchdisplay issue with contact join activity and _ on the end of custom field

[mattwire]

Overview

Steps:

1. Create a custom field on an activity with an underscore on the end of the name.
2. Create a search with contact joined to activity and grouped by contact ID.
3. See that value of custom field is shown on search.
4. Create a searchdisplay for the same.
5. See that value of custom field is not shown on search display because the key is wrong (eg. testfield_label instead of testfield__label.

Before

Bizarre failures - stuff is not displayed when you expect it to be.

After

Fields display correctly.

Technical Details

This is caused because CRM_Utils_String::munge() is called and the regex replaces _: with _.

Comments

@colemanw as we discussed in https://chat.civicrm.org/civicrm/pl/p9pupgpho3gt8rx7ko6sqhbu7o

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[colemanw]

@mattwire this is good detective work and I'm glad you found a fix. So basically the fieldname is going through conversion in 2 different places and at the end the two are compared with each other and don't match. I wonder where the second place is, and what function it uses if not munge. Ideally we should use the same function in both places to prevent any more issues like this one.

[colemanw]

Not gonna block this since it has a test, but I'd still be interested in sorting out the root cause.