Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrader - Skip snapshots on some MariaDB env's (roughly: 10.6.0-10.6.5) #27404

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Upgrader - Skip snapshots on some MariaDB env's (roughly: 10.6.0-10.6.5) #27404

merged 1 commit into from
Sep 12, 2023

Conversation

totten
Copy link
Member

@totten totten commented Sep 12, 2023

Overview

As reported by @composerjk on Mattermost, some MariaDB configurations fail to create upgrade-snapshots. Specifically, v10.6.0-10.6.5 briefly started a phase-out of support for COMPRESSED tables, but this was rolled back. Systems with this option will fail to create upgrade-snapshots.

See also: https://mariadb.com/kb/en/innodb-compressed-row-format/#read-only

Before

It tries to create upgrade-snapshots on affected systems - and fails.

After

It shows a warning that snapshots are unsupported - and then skips them. (Hopefully.)

Technical Details

I'm not running MariaDB right now, so I haven't tested this...

@civibot
Copy link

civibot bot commented Sep 12, 2023

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the 5.66 label Sep 12, 2023
@totten totten force-pushed the 5.66-snapshot-mariadb branch from 3e9c27c to 682fad1 Compare September 12, 2023 09:18
@composerjk
Copy link
Contributor

Seems good.

SELECT VERSION() has MariaDB as a substring, so the stripos() will match.
And the SELECT @@innodb_read_only_compressed returns 0 when the read_only setting is OFF. So, the check for 1 seems fine.

@colemanw colemanw merged commit db9f7d2 into civicrm:5.66 Sep 12, 2023
@totten totten deleted the 5.66-snapshot-mariadb branch September 13, 2023 03:56
demeritcowboy
demeritcowboy reviewed Sep 17, 2023
View reviewed changes
CRM/Upgrade/Snapshot.php
if (stripos($version, 'mariadb') !== FALSE) {
// MariaDB briefly (10.6.0-10.6.5) flirted with the idea of phasing-out `COMPRESSED`. By default, snapshots won't work on those versions.
// https://mariadb.com/kb/en/innodb-compressed-row-format/#read-only
$roCompressed = CRM_Core_DAO::singleValueQuery('SELECT @@innodb_read_only_compressed');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm this variable doesn't exist on mariadb 10.3 so it's a hard crash. From the docs it looks like it doesn't exist until 10.6?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR: #27464

@demeritcowboy demeritcowboy mentioned this pull request Sep 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demeritcowboy demeritcowboy demeritcowboy left review comments

@composerjk composerjk composerjk left review comments

Assignees
No one assigned
Labels
5.66
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@totten @composerjk @demeritcowboy @colemanw