Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add email helper to new form test helper #27384

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Add email helper to new form test helper #27384

merged 1 commit into from
Sep 10, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Add email helper to new form test helper

Before

After

Helper added for checking the emails sent

Technical Details

I think I've found a 5.66 regression in emails sent so getting this into 5.66 rc will help get the fix sorted there too

Comments

@civibot
Copy link

civibot bot commented Sep 9, 2023

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the 5.66 label Sep 9, 2023
seamuslee001
seamuslee001 reviewed Sep 10, 2023
View reviewed changes
tests/phpunit/CRM/Utils/Mail/IncomingTest.php Outdated
@@ -46,7 +46,7 @@ public function setUp(): void {
public function testEmailUseExistentIndividualContact(): void {
$expectedContactId = $this->individualCreate(['email' => $this->email]);

$receivedContactId = CRM_Utils_Mail_Incoming::getContactID($this->email, $this->name, TRUE);
$receivedContactId = CRM_Utils_Mail_Incoming::getContactID($this->email, $this->name, TRUE, $mail);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eileenmcnaughton $mail is not set maybe you meant $this->mail ?

@seamuslee001
Copy link
Contributor

Jenkins re test this please

@seamuslee001 seamuslee001 merged commit 5037817 into civicrm:5.66 Sep 10, 2023
@seamuslee001 seamuslee001 deleted the 566test branch September 10, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seamuslee001 seamuslee001 seamuslee001 left review comments

Assignees
No one assigned
Labels
5.66 merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @seamuslee001 @colemanw