Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PseudoConstant - Prevent fatal when entity not available #27358

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Sep 7, 2023

Overview

Prevents a hard-crash in certain scenarios when metadata is being loaded for an entity that doesn't exist. This is especially likely to happen during upgrades, particuarly the upgrade to 5.64 due to #26208

Before

More crashy

After

Less crashy

Technical Details

This can happen e.g when Views tries to lookup an option value for a disabled extension. See civicrm/civicrm-drupal#656 (comment)

@civibot
Copy link

civibot bot commented Sep 7, 2023

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@demeritcowboy
Copy link
Contributor

Thanks. Putting merge-on-pass since it does seem safe.
I'll put up a small tweak for views for e_notice.

@demeritcowboy
Copy link
Contributor

Hmm lots of test fails that seem real.

This can happen e.g when Views tries to lookup an option value for a disabled extension.
See civicrm/civicrm-drupal#656 (comment)
@colemanw colemanw force-pushed the pseudoconstantGuard branch from 4f7d124 to f16e658 Compare September 7, 2023 18:38
@colemanw
Copy link
Member Author

colemanw commented Sep 7, 2023

Take 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants