dev/core#4555 When using a Contribution Page with a Membership Price Set, the contribution amount information never shows on the thank you page

[alifrumin]

Overview

More info in https://lab.civicrm.org/dev/core/-/issues/4555

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[civibot]

The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/4555

[larssandergreen]

I noticed that this same info is missing on the confirmation page too, maybe the same changes are needed there?

[MegaphoneJon]

I know it's release day - but if this is a recent regression, should it go into the rc? I'm genuinely not sure tbh.

[alifrumin]

I updated the confirm.tpl file too.

[larssandergreen]

@MegaphoneJon It doesn't look like a recent regression in the tpl. Maybe something changed in the form class though?

[eileenmcnaughton]

There was change a few releases back that might relate - how confident are people with the change cos I think the rc would be good if people are confident - I see it has had a few eyes on

[larssandergreen]

I don't have my head wrapped around this $useForMember business, but maybe someone else does. If we're eliminating it from here, maybe it should also be eliminated from the membership online receipt, if the same change also had the same effect there (not sure, would have to be tested). Maybe it could even be eliminated entirely?

I think the regression is in 5.61, so I'm not sure it absolutely needs to be in the RC.

[alifrumin]

I agree with @larssandergreen. This fix works for the use cases I tested but I think it would be worth looking further into why it broke to begin with rather than rushing it into the RC. I can try and do that tomorrow to be more confident

[eileenmcnaughton]

@alifrumin ok cool - there was a change in the assignemtn of $useForMember that caused other problems earlier - I think this has just taken longer to surface

[eileenmcnaughton]

I think the underlying problems was that I tried to figure out what useForMember meant & standardise behaviour in the related code - but it actually turned out to be one of those hacked variables that got a value shoved into it at various points to force specific behaviours

[eileenmcnaughton]

As we are about to fork 5.66 I'm gonna merge this so it is in that rc - we can target further fixes at 5.66 & do any needed backports from there

[alifrumin]

Thanks!