APIv4 - Fix setting nullable/required/default_value field metadata #27302
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes wonky required fields in Afform by cleaning up
getFields
metadata.Before
After
Non-required fields not required by default.
Technical Details
The heart of the bug was the old PHP
"0" == FALSE
. When it checked to see if a field had a default value it would discount the number "0". This problem wasn't too apparent until we merged #22954 etc. which got misinterpreted by api getFields as making most boolean fieldsrequired
.