Update one of our complex confirm tests to use full form flow, fix discovered failure to send to additional participants

[eileenmcnaughton]

Overview

Update one of our complex confirm tests to use full form flow, fix discovered failure to send to additional participants

Before

This work was primarily about fixing the test to use the full flow. However I hit 2 bugs in the process. I fixed one in this PR & am investigating if #26987 addresses the other. The one I hit was that when confirming a event registration with additional participants they were not being emailed once I fixed the test. The reason is the code to get the participant was not only fetching the primary and was using the one it loaded last - so it would prefer a non-primary participant which meant the efforts to load the primary failed later. This wasn't an issue before I fixed the test because the participants were being loaded in the wrong order

After

Test still passes because all the participants get the email.... now that part is fixed

Technical Details

Comments

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[colemanw]

Ok looks like this also locks in the fix from #26987

[eileenmcnaughton]

@colemanw yep - the test & bug fix formed a happy union

[eileenmcnaughton]

Note the actual fix involved here is also the fix suggested in https://github.com/civicrm/civicrm-core/pull/23098/files#diff-4c9d0b1abe07057a4eea2b47bc627eecb95face8ed8d86c1c005312a52cca811R2098 - although there is a bunch of other stuff in that PR that we will probably fix using the workflow template