Pass specific ids rather than ids array #27274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
6fd2d7b to
0bf03e6
Compare
It is unclear when we pass ids what ids we care about (& in general how many ids we are using from the various functions). In fact 2 specific IDs are used (one from the _relatedObjects array) so pass these in and stop passing in ids. Also stop setting an id that we never use
0bf03e6 to
85fbe0c
Compare
|
I feel much better about merging stuff like this now that the form has solid test coverage! |
|
@colemanw actually this is from our complete payment flow - which has some of the earliest unit tests in CiviCRM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Pass specific ids rather than ids array
Before
It is unclear when we pass ids what ids we care about - we call some nasty functions to load these ids & because the usage is hard to track it is hard to stop calling the functions. In this case the only value from
$idsactually used is$eventID. In addition it grabs the$participantIDfrom a creepy arrayrelatedObjectswhen we already know itAfter
Pass in the actually-used ids and stop passing in
ids. Also stop setting an id that we never use (related_contact). Stop passing in unused$inputTechnical Details
The function is called from one well-tested place. It also receives a variable it does not use (
$input)Comments