Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Afform - Allow submissions to be disabled and limited #27211

Merged
merged 5 commits into from
Sep 4, 2023
Merged

Afform - Allow submissions to be disabled and limited #27211

merged 5 commits into from
Sep 4, 2023

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Aug 30, 2023 •
edited
Loading

Overview

Adds FormBuilder settings to disable submissions or limit the number of submissions.

image

Before

Form submissions cannot be disabled or limited.

After

image

image

@civibot
Copy link

civibot bot commented Aug 30, 2023

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Aug 30, 2023
@colemanw colemanw force-pushed the afformSubmissionLimit branch 3 times, most recently from dc1f2d3 to 2514324 Compare August 31, 2023 03:12
@colemanw colemanw marked this pull request as ready for review August 31, 2023 11:02
kurund
kurund reviewed Sep 4, 2023
View reviewed changes
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides specific comments everything else looks good to me and working as expected!

@colemanw colemanw force-pushed the afformSubmissionLimit branch from 2514324 to 92b0287 Compare September 4, 2023 14:44
kurund
kurund approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Ready to merge on test pass.

@colemanw colemanw force-pushed the afformSubmissionLimit branch from 92b0287 to 8f4118b Compare September 4, 2023 15:18
@colemanw
Copy link
Member Author

colemanw commented Sep 4, 2023

retest this please

@colemanw
Copy link
Member Author

colemanw commented Sep 4, 2023

Jenkins is having a bad day. retest this please

@colemanw colemanw merged commit 7dafa0e into civicrm:master Sep 4, 2023
@colemanw colemanw deleted the afformSubmissionLimit branch September 4, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurund kurund kurund approved these changes

Assignees
No one assigned
Labels
has-test master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colemanw @kurund