Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be able to remove clients from a case from the manage case view #27200

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Be able to remove clients from a case from the manage case view #27200

merged 1 commit into from
Aug 30, 2023

Conversation

seamuslee001
Copy link
Contributor

@seamuslee001 seamuslee001 commented Aug 30, 2023 •
edited
Loading

…e case from manage case view

Overview
This adds in the ability to remove a case client from being linked to a case from the manage case screen

Before
No way to remove a case client

After
Remove a case client possible if there are more than one case client

ping @lcdservices

@civibot
Copy link

civibot bot commented Aug 30, 2023

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Aug 30, 2023
@seamuslee001 seamuslee001 mentioned this pull request Aug 30, 2023
Closed
@seamuslee001 seamuslee001 changed the title [REF] Be able to remove clients whom are not the primary client of th… [REF] Be able to remove clients from a case from the manage case view Aug 30, 2023
@seamuslee001
Copy link
Contributor Author

Jenkins re test this please

@demeritcowboy
Copy link
Contributor

It seems like all the main feedback has been addressed 👍

@demeritcowboy demeritcowboy changed the title [REF] Be able to remove clients from a case from the manage case view Be able to remove clients from a case from the manage case view Aug 30, 2023
@seamuslee001
[REF] Be able to remove clients from the case from manage case view
3dd046f 
Modify to allow any other than the currently viewed contact to be removed from a case and create activity when it is removed

Remove restriction on link showing and convert to popup link

Only show x if there is more than 2 clients

Only Add in new activity type if CiviCase is enabled
@seamuslee001 seamuslee001 merged commit c295e7a into civicrm:master Aug 30, 2023
@seamuslee001 seamuslee001 deleted the case_remove_client branch August 30, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seamuslee001 @demeritcowboy @colemanw