Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Fix broken totals row and query output #27199

Merged
merged 1 commit into from
Sep 3, 2023

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Aug 29, 2023

Overview

Fixes SearchKit UI regression caused by #26794
See https://lab.civicrm.org/dev/core/-/issues/4548

Before

  • Fetching "Totals" row fails.
  • SQL query not shown.

After

Fixed.

@civibot
Copy link

civibot bot commented Aug 29, 2023

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the 5.65 label Aug 29, 2023
@colemanw
Copy link
Member Author

Unrelated fail

@larssandergreen
Copy link
Contributor

larssandergreen commented Sep 3, 2023

Works, looks good. Good to go.

@colemanw colemanw merged commit 6918fed into civicrm:5.65 Sep 3, 2023
@colemanw colemanw deleted the fixSkTotals branch September 3, 2023 18:52
@larssandergreen
Copy link
Contributor

Just noting this in case someone else runs into it, which is probably unlikely, but: If you created a Packaged Search before this PR was merged and after #26794, and you try to edit that Packaged Search, the sort order field will be broken as will the buttons and links blocks. Since the regression was unreleased and it's a pretty specific situation, that's OK - just noting as it is odd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants