[REF] Improve cron job handling when there is an invalid report insta… #27185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nce id passed to mail_report job
Overview
This aims to better handle cron job reporting for the job.mail_report when an invalid instance id is passed
Before
When an invalid instance id e.g. 75 on the demo sites is passed to the job.mail_report you get an error like the following back
which is because $optionVal is blank when passed through to getFieldValue but this is not obvious from the error message
After
You get an error message like the following
ping @larssandergreen @demeritcowboy @eileenmcnaughton note it is probably easier to see what is going on if you ignore whitespace by adding ?w=1 into the PR url