Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notice fix - schedule reminders #27154

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Notice fix - schedule reminders #27154

merged 1 commit into from
Aug 25, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Notice fix - schedule reminders - fixes the 'class' one - another open PR does the other

Before

image

After

image

Technical Details

Comments

@civibot
Copy link

civibot bot commented Aug 25, 2023

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers

@civibot civibot bot added the master label Aug 25, 2023
colemanw
colemanw reviewed Aug 25, 2023
View reviewed changes
CRM/Admin/Page/ScheduleReminders.php
@@ -94,6 +94,7 @@ public function browse($action = NULL) {
'ActionSchedule',
$format['id']
);
$format = array_merge(['class' => ''], $format);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You really don't like the += operator huh?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colemanw no I really don't - I thought about replying on the last one but then I tried to recall why - I know I've had unexpected results with it in the past but I can't recall any more than that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I promise it's perfectly safe. I use it all the time :)

@colemanw colemanw merged commit 47e4e7e into civicrm:master Aug 25, 2023
@colemanw colemanw deleted the notice_reminders branch August 25, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colemanw colemanw colemanw left review comments

Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw