Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused profiles from offline event receipts #27150

Conversation

larssandergreen
Copy link
Contributor

Overview

Offline event receipts can't actually show any profile fields, as these are not used from the back office — so we can remove them from the message templates.

@civibot
Copy link

civibot bot commented Aug 25, 2023

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers

@civibot civibot bot added the master label Aug 25, 2023
@eileenmcnaughton
Copy link
Contributor

@larssandergreen I just got this straight enough in my head to merge it - only to find it is now stale

I checked & yes other than this the offline forms do not show customPre or customPost which are the Profile field groups. OTOH the offline forms show all the custom fields & the online ones don't

FWIW I think the best approach is to make consistent variables available on both online & offline - but this PR (when not stale) will make that easier / more predictable to work towards

@eileenmcnaughton
Copy link
Contributor

Not sure if the tests are gonna come right here - but I've added merge-on-pass in the hope they do

@larssandergreen larssandergreen force-pushed the Remove-profiles-from-offline-event-receipts branch 2 times, most recently from 45104c4 to e9cd7fd Compare September 4, 2023 05:24
@larssandergreen larssandergreen force-pushed the Remove-profiles-from-offline-event-receipts branch from e9cd7fd to 365de7b Compare September 4, 2023 05:28
@colemanw colemanw merged commit 14729d6 into civicrm:master Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants