civicrm · demeritcowboy · Aug 24, 2023 · Aug 24, 2023 · Aug 24, 2023 · Aug 24, 2023
diff --git a/CRM/Activity/BAO/Activity.php b/CRM/Activity/BAO/Activity.php
@@ -922,7 +922,7 @@ public static function createEmailActivity($sourceContactID, $subject, $html, $t
       $details = "-ALTERNATIVE ITEM 0-\n{$html}{$additionalDetails}\n-ALTERNATIVE ITEM 1-\n{$text}{$additionalDetails}\n-ALTERNATIVE END-\n";
     }
     else {
-      $details = $html ? $html : $text;
+      $details = $html ?: $text;
       $details .= $additionalDetails;
     }
 
@@ -1703,7 +1703,7 @@ public static function getParentActivity($activityId) {
         'parent_id'
       );
 
-      $parentActivities[$activityId] = $parentId ? $parentId : FALSE;
+      $parentActivities[$activityId] = $parentId ?: FALSE;
     }
 
     return $parentActivities[$activityId];

diff --git a/CRM/Admin/Form/RelationshipType.php b/CRM/Admin/Form/RelationshipType.php
@@ -159,8 +159,8 @@ public function postProcess() {
       $params['contact_type_a'] = $cTypeA[0];
       $params['contact_type_b'] = $cTypeB[0];
 
-      $params['contact_sub_type_a'] = $cTypeA[1] ? $cTypeA[1] : 'null';
-      $params['contact_sub_type_b'] = $cTypeB[1] ? $cTypeB[1] : 'null';
+      $params['contact_sub_type_a'] = $cTypeA[1] ?: 'null';
+      $params['contact_sub_type_b'] = $cTypeB[1] ?: 'null';
 
       if (!strlen(trim($params['label_b_a'] ?? ''))) {
         $params['label_b_a'] = $params['label_a_b'] ?? NULL;

diff --git a/CRM/Campaign/Form/Survey/Results.php b/CRM/Campaign/Form/Survey/Results.php
@@ -397,7 +397,7 @@ public function postProcess() {
       $activityStatus = array_flip($activityStatus);
       $this->_params = [
         'name' => "survey_{$survey->id}",
-        'title' => $params['report_title'] ? $params['report_title'] : $this->_values['title'],
+        'title' => $params['report_title'] ?: $this->_values['title'],
         'status_id_op' => 'eq',
         // reserved status
         'status_id_value' => $activityStatus['Scheduled'],

diff --git a/CRM/Campaign/Form/Survey/TabHeader.php b/CRM/Campaign/Form/Survey/TabHeader.php
@@ -137,7 +137,7 @@ public static function getCurrentTab($tabs) {
       }
     }
 
-    $current = $current ? $current : 'main';
+    $current = $current ?: 'main';
     return $current;
   }
 
@@ -166,7 +166,7 @@ public static function getNextTab(&$form) {
       }
     }
 
-    $next = $next ? $next : 'main';
+    $next = $next ?: 'main';
     return $next;
   }
 

diff --git a/CRM/Contact/BAO/Contact.php b/CRM/Contact/BAO/Contact.php
@@ -1135,7 +1135,7 @@ public static function processImage() {
     $cid = CRM_Utils_Request::retrieve('cid', 'Positive');
     // retrieve contact id in case of Profile context
     $id = CRM_Utils_Request::retrieve('id', 'Positive');
-    $cid = $cid ? $cid : $id;
+    $cid = $cid ?: $id;
     if ($action & CRM_Core_Action::DELETE) {
       if (CRM_Utils_Request::retrieve('confirmed', 'Boolean')) {
         CRM_Contact_BAO_Contact::deleteContactImage($cid);

diff --git a/CRM/Contact/BAO/Relationship.php b/CRM/Contact/BAO/Relationship.php
@@ -2040,7 +2040,7 @@ public static function buildOptions($fieldName, $context = NULL, $props = []) {
    */
   public static function isCurrentEmployerNeedingToBeCleared($params, $relationshipId, $updatedRelTypeID = NULL) {
     $existingTypeID = (int) CRM_Core_DAO::getFieldValue('CRM_Contact_DAO_Relationship', $relationshipId, 'relationship_type_id');
-    $updatedRelTypeID = $updatedRelTypeID ? $updatedRelTypeID : $existingTypeID;
+    $updatedRelTypeID = $updatedRelTypeID ?: $existingTypeID;
     $currentEmployerID = (int) civicrm_api3('Contact', 'getvalue', ['return' => 'current_employer_id', 'id' => $params['contact_id_a']]);
 
     if ($currentEmployerID !== (int) $params['contact_id_b'] || !self::isRelationshipTypeCurrentEmployer($existingTypeID)) {

diff --git a/CRM/Contact/Form/Task/EmailTrait.php b/CRM/Contact/Form/Task/EmailTrait.php
@@ -838,7 +838,7 @@ protected function createEmailActivity($sourceContactID, $subject, $html, $text,
       $details = "-ALTERNATIVE ITEM 0-\n{$html}{$additionalDetails}\n-ALTERNATIVE ITEM 1-\n{$text}{$additionalDetails}\n-ALTERNATIVE END-\n";
     }
     else {
-      $details = $html ? $html : $text;
+      $details = $html ?: $text;
       $details .= $additionalDetails;
     }
 

diff --git a/CRM/Contribute/Form/AdditionalInfo.php b/CRM/Contribute/Form/AdditionalInfo.php
@@ -255,7 +255,7 @@ public static function processNote($params, $contactID, $contributionID, $contri
     $noteID = [];
     if ($contributionNoteID) {
       $noteID = ["id" => $contributionNoteID];
-      $noteParams['note'] = $noteParams['note'] ? $noteParams['note'] : "null";
+      $noteParams['note'] = $noteParams['note'] ?: "null";
     }
     CRM_Core_BAO_Note::add($noteParams, $noteID);
   }

diff --git a/CRM/Contribute/Form/ContributionBase.php b/CRM/Contribute/Form/ContributionBase.php
@@ -1089,7 +1089,7 @@ public function getTemplateFileName() {
    */
   public function overrideExtraTemplateFileName() {
     $fileName = $this->checkTemplateFileExists('extra.');
-    return $fileName ? $fileName : parent::overrideExtraTemplateFileName();
+    return $fileName ?: parent::overrideExtraTemplateFileName();
   }
 
   /**

diff --git a/CRM/Contribute/Form/ContributionPage/TabHeader.php b/CRM/Contribute/Form/ContributionPage/TabHeader.php
@@ -179,7 +179,7 @@ public static function getCurrentTab($tabs) {
       }
     }
 
-    $current = $current ? $current : 'settings';
+    $current = $current ?: 'settings';
     return $current;
   }
 

diff --git a/CRM/Core/BAO/Country.php b/CRM/Core/BAO/Country.php
@@ -174,7 +174,7 @@ public static function defaultContactCountryName() {
   public static function defaultCurrencySymbol($defaultCurrency = NULL) {
     static $cachedSymbol = NULL;
     if (!$cachedSymbol || $defaultCurrency) {
-      $currency = $defaultCurrency ? $defaultCurrency : Civi::settings()->get('defaultCurrency');
+      $currency = $defaultCurrency ?: Civi::settings()->get('defaultCurrency');
       if ($currency) {
         $currencySymbols = CRM_Core_PseudoConstant::get('CRM_Contribute_DAO_Contribution', 'currency', [
           'labelColumn' => 'symbol',

diff --git a/CRM/Core/BAO/Domain.php b/CRM/Core/BAO/Domain.php
@@ -273,7 +273,7 @@ public static function getGroupId() {
         $title, 'id', 'title', TRUE
       );
     }
-    return $groupID ? $groupID : FALSE;
+    return $groupID ?: FALSE;
   }
 
   /**

diff --git a/CRM/Core/Form.php b/CRM/Core/Form.php
@@ -489,7 +489,7 @@ public function &add(
     // Fudge some extra types that quickform doesn't support
     $inputType = $type;
     if ($type == 'wysiwyg' || in_array($type, self::$html5Types)) {
-      $attributes = ($attributes ? $attributes : []) + ['class' => ''];
+      $attributes = ($attributes ?: []) + ['class' => ''];
       $attributes['class'] = ltrim($attributes['class'] . " crm-form-$type");
       if ($type == 'wysiwyg' && isset($attributes['preset'])) {
         $attributes['data-preset'] = $attributes['preset'];
@@ -1397,7 +1397,7 @@ public function get_template_vars($name = NULL) {
    */
   public function &addRadio($name, $title, $values, $attributes = [], $separator = NULL, $required = FALSE, $optionAttributes = []) {
     $options = [];
-    $attributes = $attributes ? $attributes : [];
+    $attributes = $attributes ?: [];
     $allowClear = !empty($attributes['allowClear']);
     unset($attributes['allowClear']);
     $attributes['id_suffix'] = $name;

diff --git a/CRM/Core/I18n.php b/CRM/Core/I18n.php
@@ -774,7 +774,7 @@ public static  function getContactDefaultLanguage() {
    */
   public static function getLocale() {
     global $tsLocale;
-    return $tsLocale ? $tsLocale : 'en_US';
+    return $tsLocale ?: 'en_US';
   }
 
   /**

diff --git a/CRM/Core/Lock.php b/CRM/Core/Lock.php
@@ -175,7 +175,7 @@ public function acquire($timeout = NULL) {
       $query = "SELECT GET_LOCK( %1, %2 )";
       $params = [
         1 => [$this->_id, 'String'],
-        2 => [$timeout ? $timeout : $this->_timeout, 'Integer'],
+        2 => [$timeout ?: $this->_timeout, 'Integer'],
       ];
       $res = CRM_Core_DAO::singleValueQuery($query, $params);
       if ($res) {

diff --git a/CRM/Core/Menu.php b/CRM/Core/Menu.php
@@ -522,7 +522,7 @@ public static function fillComponentIds(&$menu, $path) {
           'id', 'name'
         );
       }
-      $menu[$path]['component_id'] = $componentId ? $componentId : NULL;
+      $menu[$path]['component_id'] = $componentId ?: NULL;
       $cache[$compPath] = $menu[$path]['component_id'];
     }
   }

diff --git a/CRM/Core/Page/AJAX/Location.php b/CRM/Core/Page/AJAX/Location.php
@@ -226,7 +226,7 @@ public static function getLocBlock() {
         }
         $fld = "address[1][{$element}]";
         $value = $location['address'][1][$element] ?? NULL;
-        $value = $value ? $value : "";
+        $value = $value ?: "";
         $result[str_replace([
           '][',
           '[',
@@ -244,7 +244,7 @@ public static function getLocBlock() {
       for ($i = 1; $i < 3; $i++) {
         $fld = "{$block}[{$i}][{$element}]";
         $value = $location[$block][$i][$element] ?? NULL;
-        $value = $value ? $value : "";
+        $value = $value ?: "";
         $result[str_replace([
           '][',
           '[',

diff --git a/CRM/Core/Payment/PayPalIPN.php b/CRM/Core/Payment/PayPalIPN.php
@@ -308,7 +308,7 @@ public function getInput(&$input) {
     ];
     foreach ($lookup as $name => $paypalName) {
       $value = $this->retrieve($paypalName, 'String', FALSE);
-      $input[$name] = $value ? $value : NULL;
+      $input[$name] = $value ?: NULL;
     }
 
     $input['is_test'] = $this->retrieve('test_ipn', 'Integer', FALSE);

diff --git a/CRM/Core/Payment/PayPalProIPN.php b/CRM/Core/Payment/PayPalProIPN.php
@@ -480,7 +480,7 @@ public function getInput(&$input) {
     ];
     foreach ($lookup as $name => $paypalName) {
       $value = $this->retrieve($paypalName, 'String', FALSE);
-      $input[$name] = $value ? $value : NULL;
+      $input[$name] = $value ?: NULL;
     }
 
     $input['is_test'] = $this->retrieve('test_ipn', 'Integer', FALSE);

diff --git a/CRM/Core/PseudoConstant.php b/CRM/Core/PseudoConstant.php
@@ -801,7 +801,7 @@ public static function &countryIsoCode($id = FALSE) {
    */
   public static function allGroup($groupType = NULL, $excludeHidden = TRUE) {
     $condition = CRM_Contact_BAO_Group::groupTypeCondition($groupType, $excludeHidden);
-    $groupKey = ($groupType ? $groupType : 'null') . !empty($excludeHidden);
+    $groupKey = ($groupType ?: 'null') . !empty($excludeHidden);
 
     if (!isset(Civi::$statics[__CLASS__]['groups']['allGroup'][$groupKey])) {
       self::populate(Civi::$statics[__CLASS__]['groups']['allGroup'][$groupKey], 'CRM_Contact_DAO_Group', FALSE, 'title', 'is_active', $condition);

diff --git a/CRM/Core/Selector/Controller.php b/CRM/Core/Selector/Controller.php
@@ -183,8 +183,8 @@ class CRM_Core_Selector_Controller {
   public function __construct($object, $pageID, $sortID, $action, $store = NULL, $output = self::TEMPLATE, $prefix = NULL, $case = NULL) {
 
     $this->_object = $object;
-    $this->_pageID = $pageID ? $pageID : 1;
-    $this->_sortID = $sortID ? $sortID : NULL;
+    $this->_pageID = $pageID ?: 1;
+    $this->_sortID = $sortID ?: NULL;
     $this->_action = $action;
     $this->_store = $store;
     $this->_output = $output;

diff --git a/CRM/Core/Session.php b/CRM/Core/Session.php
@@ -325,7 +325,7 @@ public function timer($name, $expire) {
     $ts = $this->get($name, 'timer');
     if (!$ts || $ts < time() - $expire) {
       $this->set($name, time(), 'timer');
-      return $ts ? $ts : 'not set';
+      return $ts ?: 'not set';
     }
     return FALSE;
   }
@@ -502,7 +502,7 @@ public static function setStatus($text, $title = '', $type = 'alert', $options =
         'text' => $text,
         'title' => $title,
         'type' => $type,
-        'options' => $options ? $options : NULL,
+        'options' => $options ?: NULL,
       ];
     }
   }

diff --git a/CRM/Event/Form/ManageEvent/TabHeader.php b/CRM/Event/Form/ManageEvent/TabHeader.php
@@ -227,7 +227,7 @@ public static function getCurrentTab($tabs) {
       }
     }
 
-    $current = $current ? $current : 'settings';
+    $current = $current ?: 'settings';
     return $current;
   }
 

diff --git a/CRM/Event/Form/Registration.php b/CRM/Event/Form/Registration.php
@@ -1126,7 +1126,7 @@ public function checkTemplateFileExists($suffix = NULL) {
    */
   public function getTemplateFileName() {
     $fileName = $this->checkTemplateFileExists();
-    return $fileName ? $fileName : parent::getTemplateFileName();
+    return $fileName ?: parent::getTemplateFileName();
   }
 
   /**
@@ -1136,7 +1136,7 @@ public function getTemplateFileName() {
    */
   public function overrideExtraTemplateFileName() {
     $fileName = $this->checkTemplateFileExists('extra.');
-    return $fileName ? $fileName : parent::overrideExtraTemplateFileName();
+    return $fileName ?: parent::overrideExtraTemplateFileName();
   }
 
   /**

diff --git a/CRM/Event/PseudoConstant.php b/CRM/Event/PseudoConstant.php
@@ -124,7 +124,7 @@ public static function &participantStatus($id = NULL, $cond = NULL, $retColumn =
       self::$participantStatus = [];
     }
 
-    $index = $cond ? $cond : 'No Condition';
+    $index = $cond ?: 'No Condition';
     $index = "{$index}_{$retColumn}";
     if (empty(self::$participantStatus[$index])) {
       self::$participantStatus[$index] = [];
@@ -183,7 +183,7 @@ public static function &participantStatusClass() {
    *   array reference of all participant roles if any
    */
   public static function &participantRole($id = NULL, $cond = NULL) {
-    $index = $cond ? $cond : 'No Condition';
+    $index = $cond ?: 'No Condition';
     if (empty(self::$participantRole[$index])) {
       self::$participantRole[$index] = [];
 

diff --git a/CRM/Logging/ReportDetail.php b/CRM/Logging/ReportDetail.php
@@ -455,7 +455,7 @@ public function getLimit($rowCount = self::ROW_COUNT_LIMIT) {
         unset($_POST['crmPID_B'], $_POST['crmPID']);
       }
 
-      $pageId = $pageId ? $pageId : 1;
+      $pageId = $pageId ?: 1;
       $offset = ($pageId - 1) * $rowCount;
 
       $offset = CRM_Utils_Type::escape($offset, 'Int');

diff --git a/CRM/Mailing/PseudoConstant.php b/CRM/Mailing/PseudoConstant.php
@@ -135,7 +135,7 @@ public static function mailingTypes() {
    *   array reference of all mailing components
    */
   public static function &component($type = NULL) {
-    $name = $type ? $type : 'ALL';
+    $name = $type ?: 'ALL';
 
     if (!self::$component || !array_key_exists($name, self::$component)) {
       if (!self::$component) {

diff --git a/CRM/Mailing/Selector/Browse.php b/CRM/Mailing/Selector/Browse.php
@@ -439,7 +439,7 @@ public function &getRows($action, $offset, $rowCount, $sort, $output = NULL) {
           $actionMask,
           [
             'mid' => $row['id'],
-            'hashOrMid' => $hash ? $hash : $row['id'],
+            'hashOrMid' => $hash ?: $row['id'],
           ],
           "more",
           FALSE,

diff --git a/CRM/PCP/Page/PCPInfo.php b/CRM/PCP/Page/PCPInfo.php
@@ -211,7 +211,7 @@ public function run() {
     }
 
     $this->assign('honor', $honor);
-    $this->assign('total', $totalAmount ? $totalAmount : '0.0');
+    $this->assign('total', $totalAmount ?: '0.0');
     $this->assign('achieved', $achieved <= 100 ? $achieved : 100);
 
     if ($achieved <= 100) {

diff --git a/CRM/Pledge/BAO/Pledge.php b/CRM/Pledge/BAO/Pledge.php
@@ -922,7 +922,7 @@ public static function updatePledgeStatus(array $params): array {
           // 2. send acknowledgement mail
           if ($toEmail && !($doNotEmail || $onHold)) {
             // assign value to template
-            $template->assign('amount_paid', $details['amount_paid'] ? $details['amount_paid'] : 0);
+            $template->assign('amount_paid', $details['amount_paid'] ?: 0);
             $template->assign('next_payment', $details['scheduled_date']);
             $template->assign('amount_due', $details['amount_due']);
             $template->assign('checksumValue', $details['checksumValue']);

diff --git a/CRM/Profile/Form.php b/CRM/Profile/Form.php
@@ -770,7 +770,7 @@ public function buildQuickForm(): void {
           $return = TRUE;
           if (!$statusMessage) {
             $statusMessage = ts("This profile is configured for contact type '%1'. It cannot be used to edit contacts of other types.",
-                [1 => $profileSubType ? $profileSubType : $profileType]);
+                [1 => $profileSubType ?: $profileType]);
           }
         }
       }
@@ -1367,7 +1367,7 @@ public function checkTemplateFileExists($suffix = NULL) {
    */
   public function getTemplateFileName() {
     $fileName = $this->checkTemplateFileExists();
-    return $fileName ? $fileName : parent::getTemplateFileName();
+    return $fileName ?: parent::getTemplateFileName();
   }
 
   /**
@@ -1378,7 +1378,7 @@ public function getTemplateFileName() {
    */
   public function overrideExtraTemplateFileName() {
     $fileName = $this->checkTemplateFileExists('extra.');
-    return $fileName ? $fileName : parent::overrideExtraTemplateFileName();
+    return $fileName ?: parent::overrideExtraTemplateFileName();
   }
 
   /**

diff --git a/CRM/Profile/Page/Dynamic.php b/CRM/Profile/Page/Dynamic.php
@@ -420,7 +420,7 @@ public function checkTemplateFileExists($suffix = NULL) {
    */
   public function getTemplateFileName() {
     $fileName = $this->checkTemplateFileExists();
-    return $fileName ? $fileName : parent::getTemplateFileName();
+    return $fileName ?: parent::getTemplateFileName();
   }
 
   /**
@@ -431,7 +431,7 @@ public function getTemplateFileName() {
    */
   public function overrideExtraTemplateFileName() {
     $fileName = $this->checkTemplateFileExists('extra.');
-    return $fileName ? $fileName : parent::overrideExtraTemplateFileName();
+    return $fileName ?: parent::overrideExtraTemplateFileName();
   }
 
   /**

diff --git a/CRM/Profile/Page/Listings.php b/CRM/Profile/Page/Listings.php
@@ -483,7 +483,7 @@ public function checkTemplateFileExists($suffix = NULL) {
    */
   public function getTemplateFileName() {
     $fileName = $this->checkTemplateFileExists();
-    return $fileName ? $fileName : parent::getTemplateFileName();
+    return $fileName ?: parent::getTemplateFileName();
   }
 
   /**
@@ -494,7 +494,7 @@ public function getTemplateFileName() {
    */
   public function overrideExtraTemplateFileName() {
     $fileName = $this->checkTemplateFileExists('extra.');
-    return $fileName ? $fileName : parent::overrideExtraTemplateFileName();
+    return $fileName ?: parent::overrideExtraTemplateFileName();
   }
 
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -179,7 +179,7 @@ public static function getCurrentTab($tabs) { @@
           }
         }
-        $current = $current ? $current : 'settings';
+        $current = $current ?: 'settings';
         return $current;
       }
@@ Expand Down @@