Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpunit.xml.dist - Update extensions to use phpunit9 format #27133

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

totten
Copy link
Member

@totten totten commented Aug 24, 2023

Overview

Since we're switch the core extensions to run tests on phpunit9 (civicrm/civicrm-buildkit#811), we should also update format.

cc @seamuslee001

Before

[bknix-min:~/bknix/build/dmaster/web/sites/all/modules/civicrm/ext/financialacls] phpunit9 
PHPUnit 9.6.5 by Sebastian Bergmann and contributors.

Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

After

Quiet

totten added 2 commits August 23, 2023 20:58
This makes the phpunit.xml for the ext's match style of the main one.

This makes it easier to see future changes in a diff.
@civibot
Copy link

civibot bot commented Aug 24, 2023

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers

@civibot civibot bot added the master label Aug 24, 2023
@totten
Copy link
Member Author

totten commented Aug 24, 2023

Since #811 was just merged, it may take a moment before it rolls out. Based on some spot-checking, I'd expect these files to work either way (with phpunit8 or phpunit9) - but phpunit8 would show some opposite warnings on the console.

@seamuslee001
Copy link
Contributor

Jenkins retest this please

@colemanw
Copy link
Member

Retest this please

@demeritcowboy demeritcowboy merged commit ce23d17 into civicrm:master Aug 24, 2023
@totten totten deleted the master-phpunit-xml branch August 25, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants