-
-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standalone: Fix ACL help/links, tweak Users and Permissions menu #27119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷 Introduction for new contributors
Quick links for reviewers |
artfulrobot
reviewed
Aug 23, 2023
artfulrobot
reviewed
Aug 23, 2023
Thanks, this looks good pending couple of comments made on the code. |
469eafb
to
16ef222
Compare
16ef222
to
a9e6a37
Compare
Looks good to me. Thanks @mlutfy |
Thanks @artfulrobot ! I took the liberty of adding MOP tag to the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
On CiviCRM Standalone:
Also, the "Manage Users" and Roles links are not under "Users and Permissions".
This PR changes the following:
ufAccessURL
so that it leads to lead to manage "User roles"Before
Navigation menu:
After
Comments
Moving the menu items: I realize this hinders discoverability a bit, but I think it also declutters, therefore making menu navigation easier.
Reported by dsp3926 on the standalone chat
cc @artfulrobot