Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump search_autocomplete_count default from 10 to 15 #27116

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

colemanw
Copy link
Member

Overview

Improves the overall responsiveness of Autocompletes by fetching more results at a time.

Before

Ajax requests can be slow.

After

Fetching 50% more will add a negligible amount of time to each request, but cut down on the number of requests.

Comments

Bikesheddy question of whether it should be 15 or 20 but I think it's safe to say that 10 is too few so at least this is better.

@civibot
Copy link

civibot bot commented Aug 22, 2023

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers

@colemanw colemanw force-pushed the search_autocomplete_count branch from d63078d to 0247932 Compare August 22, 2023 01:20
@eileenmcnaughton
Copy link
Contributor

OK - makes sense

@eileenmcnaughton eileenmcnaughton merged commit 024180e into civicrm:master Aug 22, 2023
@eileenmcnaughton eileenmcnaughton deleted the search_autocomplete_count branch August 22, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants