Fix undeclared property - use locally scoped variable

[eileenmcnaughton]

Overview

Addresses

CRM_Event_Form_ManageEvent_LocationTest::testSubmit
Creation of dynamic property CRM_Event_Form_ManageEvent_Location::$_doneUrl is deprecated

/home/homer/buildkit/build/build-0/web/sites/all/modules/civicrm/CRM/Event/Form/ManageEvent.php:197
/home/homer/buildkit/build/build-0/web/sites/all/modules/civicrm/CRM/Event/Form/ManageEvent/Location.php:67
/home/homer/buildkit/build/build-0/web/sites/all/modules/civicrm/tests/phpunit/CRM/Event/Form/ManageEvent/LocationTest.php:281
/home/homer/buildkit/build/build-0/web/sites/all/modules/civicrm/tests/phpunit/CRM/Event/Form/ManageEvent/LocationTest.php:28
/home/homer/buildkit/build/build-0/web/sites/all/modules/ci

Before

Undeclared property

After

locally scoped variable

Technical Details

The undeclared property is not used outside the function - I also moved the breadcrumbing function into the if so less variable wrangling was needed

Comments

[civibot]

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers

• ➡️ Demo site for this PR
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

[eileenmcnaughton]

test fail unrelated - currently hitting all/many PRs

api\v4\Entity\ActionScheduleTest::testGetOptionsBasic
Failed asserting that an array contains Array &0 (
'id' => '1'
'name' => 'activity_type'
'label' => 'Activity'
'icon' => 'fa-tasks'
).

/home/homer/buildkit/build/build-1/web/sites/all/modules/civicrm/tests/phpunit/api/v4/Entity/ActionScheduleTest.php:31
/home/homer/buildkit/extern/phpunit9/phpunit9.phar:2307