Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue dev/backdrop#80: global $language should be an object. #27038

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

bugfolder
Copy link
Contributor

Overview

Fixes https://lab.civicrm.org/dev/backdrop/-/issues/80.

Before

In Backdrop CMS, the global variable $language was set to a string (e.g., "English"), rather than an object, as it is supposed to be set.

This causes warnings and incorrect results whenever the objects variables are accessed, e.g., $langcode = $language->langcode;.

After

It is now set to the appropriate object.

Technical Details

The function whose call is being changed is documented here.

@civibot
Copy link

civibot bot commented Aug 10, 2023

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers

@civibot civibot bot added the master label Aug 10, 2023
@seamuslee001
Copy link
Contributor

@herbdool I think this looks right to me can you confirm?

@seamuslee001 seamuslee001 added the merge ready PR will be merged after a few days if there are no objections label Aug 10, 2023
@seamuslee001 seamuslee001 changed the title Issue #80: global $language should be an object. Issue dev/backdrop#80: global $language should be an object. Aug 10, 2023
@herbdool
Copy link
Contributor

@seamuslee001 yup, looks good.

@colemanw colemanw merged commit fee3ef3 into civicrm:master Aug 11, 2023
@bugfolder bugfolder deleted the 80_global_language branch August 11, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants