Unit tests - replace deprecated function with newer one

[eileenmcnaughton]

Overview

Unit tests - replace deprecated function with newer one
Also minor clean ups

Before

$this->assertRegexp is deprecated

After

$this->assertMatchesRegularExpression

Technical Details

I think we are on COMMAND: phpunit9 (/home/jenkins/bknix-dfl/bin/phpunit9)

PHPUnit 9.6.5 by Sebastian Bergmann and contributors.

• which would allow us to use forward friendly functions

Comments

PHP 10 is min version 8.1 - so we should prepare for it but can't switch to it

[civibot]

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers

• ➡️ Demo site for this PR
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

[totten]

I'm not certain that we switched... but if it passes, then merge it. 👍

[eileenmcnaughton]

Hmm no it is PHPUnit 8.5.27 #StandWithUkraine - I wonder what is holding us back from switching

[eileenmcnaughton]

@seamuslee001 do you recall?

[seamuslee001]

I don't think there is anything but you would need to modify this https://github.com/civicrm/civicrm-core/blob/master/tools/scripts/phpunit#L95 I think and there would be something in buildkit to modify for the core extensions as well

[eileenmcnaughton]

OK - let's see if it passes #27036 it so we can merge & re-try this

[seamuslee001]

Jenkins retest this please