Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate getStatusMessage function #27015

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Aug 7, 2023

Overview

Separate getStatusMessage function

Before

Parent & child class use the same getStatusMessage function but follow different paths within it

After

Child class implements the function itself, functionality separated

Technical Details

The CRM_Event_Form_Task_Register form was once part of CRM_Event_Form_Participant

It now extends it & the goal is to disentangle it from the parent.

In general _single is only set for the parent & describes actions for that whereas the Register form is a task that can act on many

Comments

The  CRM_Event_Form_Task_Register form was once part of CRM_Event_Form_Participant

It now extends it & the goal is to disentangle it from the parent.

In general _single is only set for the parent & describes actions for that
whereas the Register form is a task that can act on many
@civibot
Copy link

civibot bot commented Aug 7, 2023

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers

@civibot civibot bot added the master label Aug 7, 2023
@seamuslee001
Copy link
Contributor

Jenkins re test this please

@larssandergreen
Copy link
Contributor

Looks good, r-run good.

@larssandergreen larssandergreen added the merge ready PR will be merged after a few days if there are no objections label Aug 7, 2023
@colemanw colemanw merged commit 670739f into civicrm:master Aug 7, 2023
@colemanw colemanw deleted the extend branch August 7, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants