5.65.alpha1 - Define pre-upgrade snapshots (Option A) #26998
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
For data-structures that are modified by the 5.65.alpha1 upgrade, create some snapshots (just in case we discover some schema problem later on).
This is one of two options. Option A uses the existing PHP methods for creating the snapshot. It supports paginating the operations. However, this doesn't seem very important since these datasets are generally fairly small (dozens of records -- at a stretch, maybe a couple thousand records).
(For Option B, see #26999.)
Before
After
Comments
There's an open PR #26993 which would add another upgrade test.since these datasets are generally fairly small (dozens of records -- at a stretch, maybe a couple thousand records).
Before
After
Comments
There's an open PR #26993 which would add another upgrade test. I included the corresponding snapshot for that as well - but it's a separate commit (in case we need some cherry-picking/reconsideration of that one).