dev/core#4453 fix clash over 'name' field on contribution page form #26953
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
dev/core#4453 fix clash over 'name' field on contribution page form
Before
Error on saving on php8.x
After
better
Technical Details
As @larssandergreen identified the issue is we are now loading the
name
field into the defaults and it using a different variable type compared to the quickform field. The reason we are loading name is that we are using a really blunt function to load everything - even the fields we don't need. I added code to unset name & 2 other entity properties that are not exposed as fieldsComments
@larssandergreen