Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone civi-setup: grant more permissions to anon, use ts #26934

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

mlutfy
Copy link
Member

@mlutfy mlutfy commented Jul 26, 2023

Overview

In the default Standalone install, also grant the permissions to:

  • view event info
  • register for online events

This also aims to help with the demo sites, but also towards providing sane out-of-the-box defaults (I forget if "view profiles" and "view all custom data" is required for contribution/event pages, but I guess it works without).

Also used ts for the role labels.

cc @artfulrobot

@civibot
Copy link

civibot bot commented Jul 26, 2023

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers

@artfulrobot
Copy link
Contributor

@mlutfy I don't get how to read the test fails - I can't see what's failing (and whether it is meaningful)?

But looks good to me.

@mlutfy
Copy link
Member Author

mlutfy commented Jul 26, 2023

jenkins, test this please

@mlutfy
Copy link
Member Author

mlutfy commented Jul 26, 2023

Mysterious matrix test fail:

ok 458 - CRM_Contact_BAO_ContactTest::testAgeOfDeceasedContact
ok 459 - CRM_Contact_BAO_ContactTest::testAgeOfNormalContact
ok 460 - CRM_Contact_BAO_ContactTest::testInvalidateChecksumHook

Installing build0test_u6xad database
FATAL: command execution failed
Command Close created at
[...]
	at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:81)
Caused: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@6d83a5eb:bknix-run-zsciuc": Remote call on bknix-run-zsciuc failed. The channel is closing down or has closed down

re-ran again:

ok 460 - CRM_Contact_BAO_ContactTest::testInvalidateChecksumHook

Installing build0test_u6xad database
FATAL: command execution failed
[...]

@mlutfy
Copy link
Member Author

mlutfy commented Jul 26, 2023

jenkins, test this please

@mlutfy
Copy link
Member Author

mlutfy commented Jul 26, 2023

I'm a bit confused how the matrix tests failed at first, and now it's fine, but maybe my "test this please" were too quick. Considering it's small change, taking the liberty to merge.

@mlutfy mlutfy merged commit 98e6da6 into civicrm:master Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants