Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AdminUI - Add Administer Scheduled Reminders page #26896

Merged
merged 4 commits into from
Jul 24, 2023
Merged

AdminUI - Add Administer Scheduled Reminders page #26896

merged 4 commits into from
Jul 24, 2023

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jul 21, 2023 •
edited
Loading

Overview

Add new screen to the Admin UI Extension.

Before

image

After

image

Technical Details

Added a lot of dynamic metadata so that options appeared correctly for a given type. Dynamic option lists are great; it even pluralizes the units correctly ("4 Days" vs "1 Day").

colemanw added 2 commits July 21, 2023 11:13
@colemanw
DAO - Add 'fillValues' utility function to facilitate looking up fiel…
c1bf8a7 
…ds from an incomplete record.
@colemanw
Pseudoconstant - Standardize callback params
7ea896a 
Before: pseudoconstant callbacks received different params depending on where they were being called from
After: Standardized on ($fieldName, $params)

Note: The previous $context arg is useless and also contained in $params if it's really needed.
@civibot
Copy link

civibot bot commented Jul 21, 2023

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers

@civibot civibot bot added the master label Jul 21, 2023
@colemanw colemanw changed the title Mapping metadata AdminUI - Add Administer Scheduled Reminders page Jul 21, 2023
@aydun
Copy link
Contributor

aydun commented Jul 24, 2023

Test this please

aydun
aydun reviewed Jul 24, 2023
View reviewed changes
ext/civicrm_admin_ui/managed/SavedSearch_Administer_Scheduled_Reminders.mgd.php
'dataType' => 'Date',
'label' => E::ts('When'),
'sortable' => TRUE,
'empty_value' => '[start_action_offset] [start_action_unit:label] [start_action_condition] [start_action_date:label]',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's clever!

@aydun aydun merged commit 6cf0f3c into civicrm:master Jul 24, 2023
@aydun
Copy link
Contributor

aydun commented Jul 24, 2023

All seems to work well. Great to see this pushing some boundaries!

@colemanw colemanw deleted the mappingMetadata branch July 24, 2023 12:27
@colemanw
Copy link
Member Author

Thanks for the review @aydun

@colemanw colemanw mentioned this pull request Aug 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aydun aydun aydun left review comments

Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colemanw @aydun