[REF] ScheduleReminders - Cleanup "sublimely stupid" form code

[colemanw]

Overview

Initial cleanup of the ScheduleReminders form... toward sanity.
Lots more refactoring to do, this fixes the easy-to-fix things that were obviously wrong.

[civibot]

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers

• ➡️ Demo site for this PR
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

[colemanw]

This is easily my favorite comment in our codebase. I'm sorry to see it go @totten

[totten]

Well, I guess that code had to wander 7 years through the wilderness, but now... it's sublimely smart... I hope...

[seamuslee001]

Jenkins re test this please

[colemanw]

@seamuslee001 was that just a drive-by comment or were you gonna merge this?

[seamuslee001]

ok this seems ok

[totten]

I played around with it a bit on the test site -- it exhibited consistency in writing/reading the "Entity"-related options. So that seems good.

My process was to make one "Scheduled Reminder", then repeatedly edit it (changing the "Entity" to some random values). There were a few PHP warnings. I haven't tested carefully enough to see if they originate here.

[colemanw]

@totten yea, that's because the form has to do its own deserialization of the values from BAO::retrieve because that function sucks. I'll get to that...