Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up fix (master only regression) #26851

Merged
merged 1 commit into from
Jul 16, 2023
Merged

Follow up fix (master only regression) #26851

merged 1 commit into from
Jul 16, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

@civibot
Copy link

civibot bot commented Jul 16, 2023

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers

@civibot civibot bot added the master label Jul 16, 2023
@eileenmcnaughton eileenmcnaughton mentioned this pull request Jul 16, 2023
Merged
@eileenmcnaughton eileenmcnaughton changed the title Follow up fix Follow up fix (master only regression) Jul 16, 2023
@eileenmcnaughton
Copy link
Contributor Author

I'm going to self merge this cos the newly merged regresion will be disruptive

@demeritcowboy

@eileenmcnaughton eileenmcnaughton merged commit 17c57d3 into civicrm:master Jul 16, 2023
@eileenmcnaughton eileenmcnaughton deleted the unshared branch July 16, 2023 06:35
@demeritcowboy
Copy link
Contributor

Thanks @eileenmcnaughton

@demeritcowboy
Copy link
Contributor

I don't think this was enough. There are still references to $form in preprocess, the errors are just hidden by ajax. e.g. Warning: Undefined variable $form in CRM_Custom_Form_CustomDataByType->preProcess() (line 60

@eileenmcnaughton
Copy link
Contributor Author

@demeritcowboy #26872 - just doing the write up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @demeritcowboy