Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dev/core#4414) Greenwich - Fix icon path #26831

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

totten
Copy link
Member

@totten totten commented Jul 14, 2023

Overview

This fixes an issue where the Greenwich Bootstrap files include an invalid reference to their font data.

https://lab.civicrm.org/dev/core/-/issues/4414

ping @agileware-justin

Before

If you use (e.g.) Mosaico's "New Mailing", then browser console shows a failed request for

http://dmaster.127.0.0.1.nip.io:8001/sites/all/modules/civicrm/ext/greenwich/fonts/glyphicons-halflings-regular.woff2

Visually, on the third tab ("Options"), this button is malformed:

Screen Shot 2023-07-14 at 4 38 49 PM

After

In the same use-case, the browser makes a successful request for

http://dmaster.127.0.0.1.nip.io:8001/sites/all/modules/civicrm/ext/greenwich/extern/bootstrap3/assets/fonts/bootstrap/glyphicons-halflings-regular.woff2

The button is OK.

Screen Shot 2023-07-14 at 4 39 10 PM

Technical Details

To apply the patch, one needs to:

  1. Use the included update for _greenwich.scss
  2. Re-run composer compile (or composer install)
  3. (For D9+) Re-run composer civicrm:publish

@civibot
Copy link

civibot bot commented Jul 14, 2023

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers

@civibot civibot bot added the 5.64 label Jul 14, 2023
@agileware-justin
Copy link
Contributor

Thanks @totten looks correct to me.

@seamuslee001
Copy link
Contributor

I'm going to merge based on @agileware-justin feedback

@seamuslee001 seamuslee001 merged commit 6b15b28 into civicrm:5.64 Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants