Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add start date back to recurring contributions display on contact - RC #26811

Conversation

larssandergreen
Copy link
Contributor

Overview

Follow up adding start date back to recurring contributions on contact due to user feedback, see #26151. Don't love that this breaks onto two lines, but not sure there's a way around that, hopefully folks who care about this have set a more reasonable date format.

Before

image

After

image

@civibot
Copy link

civibot bot commented Jul 13, 2023

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers

@civibot civibot bot added the 5.64 label Jul 13, 2023
@larssandergreen larssandergreen changed the title Add start date back to recurring contributions display on contact Add start date back to recurring contributions display on contact - RC Jul 13, 2023
@eileenmcnaughton eileenmcnaughton merged commit 04f1976 into civicrm:5.64 Jul 14, 2023
wmfgerrit pushed a commit to wikimedia/wikimedia-fundraising-crm that referenced this pull request Jul 18, 2023
This pulls in things that have been merged to the
upstream rc since we deployed and also reverts
the temporary patches we applied in order to get the
upgrade script to run better.

It is general housekeeping to keep grabbing the latest
patches for our point version. But we also
specifically want this patch
civicrm/civicrm-core#26811 to
revert the loss of the start date fields

Patches merged to the rc since it was cut are here
https://github.com/civicrm/civicrm-core/pulls?q=is%3Apr+is%3Aclosed+label%3A5.64
(although some of those were already merged when we pushed it out).

Note this isn't in the sprint but it's better to get back to a
'stock' deployment before porting in the patch
that I'm actually work on - ie
civicrm/civicrm-core#26867
Bug: T341877

Change-Id: Ib6532188782545950441a42413d8751cd04b503d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants