dev/core#4430 Fix regression on searching for emails

[eileenmcnaughton]

Overview

dev/core#4430 Fix regression on searching for emails

See screenshots in https://lab.civicrm.org/dev/core/-/issues/4430

Before

Not possible to search for a partial email in (e.g)advanced search fails because the email fails html-layer validation & won't submit

See https://dmaster.demo.civicrm.org/civicrm/contact/search/advanced?reset=1

Note settings

After

html type is rendered as 'Text' not 'Email'

Technical Details

We hit this in the 5.64rc & I believe it does not need to go back to stable - #26705

Comments

[civibot]

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers

• ➡️ Demo site for this PR
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

[civibot]

The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/4430

[kcristiano]

Thanks @eileenmcnaughton I missed this in testing.

I confirm that the problem exists when searching.

I've done an r-run and confirm this fixes the regression.

The original PR still allows validation on Form Builder Forms as it should. This looks good to merge.

[totten]

Thank you @kcristiano.