dev/core#4418 Fix Payment Processor accepted_credit_cards regression

[larssandergreen]

Overview

Edit: Turns out you have to pass the values to the API as an array, not as JSON.
See issue #4418

Before

accepted_credit_cards not saved.

After

Works

[civibot]

Thank you for contributing to CiviCRM! ❤️ Here's what's next:

• If this is your first PR, an admin will greenlight automated testing with the command "add to whitelist".
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command "test this please" to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• Here are some handy links for reviewers:
  • Demo site for this PR
  • Review standards
  • Review template

[civibot]

The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/4418

[eileenmcnaughton]

Thanks @larssandergreen - I guess master IS the rc right now.

@colemanw any appetitie to fix 'the right way' (support json in apiv4) or should we just go with this -- note more detail on the gitlab

[seamuslee001]

so is the problem that we are JSON encoding the field before its passed to APIv4 and then v4 is JSON encoding again?

[larssandergreen]

@seamuslee001 Yes, you're right. I'll change this!

[seamuslee001]

ok I believe this is the correct fix noting that we now have a unit test (currently failing here #26758 ) for this form now that will pass when this is merged and 5.64 #26760 and 5.63 #26761 upgrade scripts to fix any bad data in the database