add contactId to params array in EmailTrait

[masetto]

Overview

Add contactId to params array in EmailTrait calling wrapper function send email.
Related to add contact_id to email params in emailLetter function.

Before

Params array of alterMailParams hook does not contain contactId when context is singleEmail.

After

Params array of alterMailParams hook contains contactId when context is singleEmail.

Comments

These comments are not referring to this PR, but to the alterMailParams hook that I encountered while during my testing.

When I send a single email alterMailParams hook is called 2 times: one for context messageTemplate and one for singleEmail. I have no way of knowing whether it is called only for rendering the template or for sending the email: respectively functions CRM_Core_BAO_MessageTemplate:renderTemplate and CRM_Core_BAO_MessageTemplate:sendTemplate.

In this hook I add attachments for context messageTemplate, these attachments are ignored because function sendMessage is called ignoring the attachements in rendered template (see row 796 of CRM_Contact_Form_Task_EmailTrait class).

Finally, I do not understand why CRM_Contribute_Form_Task_PDFLetter does not use CRM_Contact_Form_Task_EmailTrait trait.

Let me know if you think there are things that can be improved in this PR. If not, I can open issues.

[civibot]

Thank you for contributing to CiviCRM! ❤️ Here's what's next:

• If this is your first PR, an admin will greenlight automated testing with the command "add to whitelist".
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command "test this please" to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• Here are some handy links for reviewers:
  • Demo site for this PR
  • Review standards
  • Review template

[yashodha]

@masetto looks good, merging this PR.