🌶️ dev/core/-/issues/4416 CiviCRM 5.63.0 - Regression, Mailing click tracking now returns: Error 500 malformed header from script 'url.php': Bad header for all tracked URLs

[agileware-justin]

Overview

CiviCRM 5.63.0 - Regression, Mailing click tracking now returns: Error 500 malformed header from script 'url.php': Bad header for all tracked URLs.

eg, https://flippythongs.org.au/wp-content/plugins/civicrm/civicrm/extern/url.php?u=4238&qid=201344 returns error 500

Reported on Gitlab, https://lab.civicrm.org/dev/core/-/issues/4416

Before

Mailing click tracking no longer works.

After

Mailing click tracking no works again, rejoice!

Technical Details

CiviCRM 5.63.0 regression

Comments

This bug warrants a new CiviCRM release IMHO.

Agileware Ref: CIVICRM-2150

[civibot]

Thank you for contributing to CiviCRM! ❤️ Here's what's next:

• If this is your first PR, an admin will greenlight automated testing with the command "add to whitelist".
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command "test this please" to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• Here are some handy links for reviewers:
  • Demo site for this PR
  • Review standards
  • Review template

[larssandergreen]

I have reviewed, code is obviously correct, r-run shows works as intended.

As to the urgency of the new release, I'm unable to reproduce the malformed header issue locally. You have to be using Admin > System Settings > Resource URLs > Extern URL Style = Prefer standalone scripts instead of the default Prefer normal router. For me, Apache is just ignoring the incorrect header and proceeding without it. But evidently it's an issue on at least one config!

[MegaphoneJon]

Ugh, this was me. A stupid mistake, and one I obviously didn't test thoroughly.

[colemanw]

It's an easy mistake since most functions that wrap header take 2 args (e.g. CRM_Utils_System::setHttpHeader)
But this PR raises a bigger question for me... should there be a style-guide for using emojis in PR titles? Obviously, emojis are very technical and precise, so we need to establish syntax standards. If 🌶️ means regression, I suppose 🕷️ means bug? But are arachnids bugs? Maybe 🐞 for cute bugs and 🐛 for ugly bugs?