CRM_Mailing_Form_Optout, CRM_Mailing_Form_Unsubscribe: change properties to protected from private

[semseysandor]

Overview

I'd like to hook into the Opt-out and Unsubscribe process but job_id, queue_id and hash are declared private so they are not accessible.

Before

CRM_Core_Form::getVar('_job_id') returns null

After

CRM_Core_Form::getVar('_job_id') returns correct Job ID.

Technical Details

They were declared with private visibility in #21350. Before that they were undefined properties so changing visibility to protected shouldn't break any encapsulation as originally there were public. I think private here is just too strict.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Makes sense!