Move Custom Group search test to extension, remove xml brittleness #26660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
ee3088c to
8746522
Compare
8746522 to
7f00b9c
Compare
|
Nice work @eileenmcnaughton |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Move Custom Group search test to extension, remove xml brittleness
Before
Search is not in the extension, although what it is testing is
After
Moved to an extension, xml no longer used for set up
Technical Details
I also moved a small chunk of custom search code to the extension
https://github.com/civicrm/civicrm-core/pull/26660/files#diff-c618d092bb71d85dc1b5c64a6e49e090cc6cbbfb5e3da4f8551cb46b82db6dffL160
Comments