Switch to Payment.create & repeattransaction in Authorize.net #26620
Conversation
|
(Standard links)
|
|
this seems fine |
| @@ -3816,6 +3816,7 @@ public static function isSingleLineItem($id) { | |||
| */ | |||
| public static function completeOrder($input, $recurringContributionID, $contributionID, $isPostPaymentCreate = FALSE) { | |||
| if (!$contributionID) { | |||
| CRM_Core_Error::deprecatedFunctionWarning('v3api Contribution.repeattransaction. This handling will be removed around 5.70 (calling this function directly has never been supported outside core anyway)'); | |||
There was a problem hiding this comment.
@mattwire it's the end of an era!!!
There was a problem hiding this comment.
@eileenmcnaughton Shouldn't this say "Contribution.completetransaction"?
There was a problem hiding this comment.
@mattwire nope - this is the calling of completeOrder to call repeattransaction that is deprected
There was a problem hiding this comment.
ok, the comment confuses me :-)
|
@eileenmcnaughton This has caused a regression. There doesn't seem to be any test coverage catching it but expected behaviour for the contribution trxn_id is that it concatenates with payment trxn_ids. This has triggered a bunch of test failures in Stripe: See https://github.com/SemperIT/CiviCARROT/actions/runs/5370451060/jobs/9742545452 |
| @@ -188,6 +188,7 @@ public static function create(array $params): CRM_Financial_DAO_FinancialTrxn { | |||
| 'is_post_payment_create' => TRUE, | |||
| 'is_email_receipt' => $params['is_send_contribution_notification'], | |||
| 'trxn_date' => $params['trxn_date'], | |||
| 'trxn_id' => $params['trxn_id'] ?? NULL, | |||
There was a problem hiding this comment.
This line has caused a regression and change in behaviour in CiviCRM core - see comment on main PR and test failures https://github.com/SemperIT/CiviCARROT/actions/runs/5370451060/jobs/9742545452
Overview
Switch to Payment.create & repeattransaction in Authorize.net
Before
completeOrdercalled for both repeattransaction and payment.create/completetransactionAfter
Api calls to
Payment.create&Contribution.repeattransactionTechnical Details
Comments