Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2549 #26605

Merged
merged 1 commit into from
Jun 23, 2023
Merged

dev/core#2549 #26605

merged 1 commit into from
Jun 23, 2023

Conversation

samuelsov
Copy link
Contributor

Overview

c.f. https://lab.civicrm.org/dev/core/-/issues/2549

Before

Merging contact always merge websites even if the checkbox to copy is not checked

Comments

There is a special treatment for table with location that are found in CRM/Dedupe/Merger.php::getLocationBlockInfo

Even if the websites does not have a location, they are going through the same process.

Added civicrm_im as well which as the same issue.

Ideally locTables and getLocationBlockInfo should be linked somehow to avoid adding info to one without doing it for the other.

@civibot
Copy link

civibot bot commented Jun 22, 2023

No issue was found matching the number given in the pull request title. Please check the issue number.

@civibot
Copy link

civibot bot commented Jun 22, 2023

(Standard links)

@civibot civibot bot added the master label Jun 22, 2023
@larssandergreen
Copy link
Contributor

Could we add table to each array in getLocationBlockInfo and then just call getLocationBlockInfo and pull those out here?

@eileenmcnaughton
Copy link
Contributor

You missed open ID :-)

@eileenmcnaughton eileenmcnaughton merged commit b25746b into civicrm:master Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants