Fix e-notices in contribution_offline_receipt text by removing always-empty field #26599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-empty field On looking to fix this enotice through the form it turned out the contribution form does not have a field for this - so the formValues will never hold receipt_text. Hence this PR removes it from the template. Other forms do seem to have this & I will separately add userText or similar to the model
|
(Standard links)
|
|
I've actually thought that we should add this field to the form. It's odd that we have it for events, but not contributions. Would be useful, especially as most receipts are very generic since they have to cover all types of contributions. |
|
@larssandergreen I'm OK with it being added but I think we would assign it differently if we do re-add it so I think it's OK to remove this - I can put up another PR on another form showing... |
|
Sounds good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix e-notices in contribution_offline_receipt text by removing always-empty field
Before
offline receipt template has a place for the receipt_text field from the form - but there is no receipt text field on the form - this is e-noticey
After
poof
Technical Details
On looking to fix this enotice through the form it turned out the contribution form does not have a field for this - so the formValues will never hold receipt_text.
Hence this PR removes it from the template.
Other forms do seem to have this & I will separately add userText or similar to the model
Comments